Bug 222996 - CRASH in MergeUVRow_AVX2
Summary: CRASH in MergeUVRow_AVX2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-09 14:48 PST by Jer Noble
Modified: 2021-03-10 13:56 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.75 KB, patch)
2021-03-09 14:55 PST, Jer Noble
ggaren: review+
Details | Formatted Diff | Diff
Patch for landing (3.52 KB, patch)
2021-03-10 09:20 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-03-09 14:48:59 PST
CRASH in MergeUVRow_AVX2
Comment 1 Jer Noble 2021-03-09 14:49:38 PST
<rdar://75183835>
Comment 2 Radar WebKit Bug Importer 2021-03-09 14:49:57 PST
<rdar://problem/75236308>
Comment 3 Jer Noble 2021-03-09 14:55:46 PST
Created attachment 422764 [details]
Patch
Comment 4 Geoffrey Garen 2021-03-09 15:24:21 PST
Comment on attachment 422764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422764&action=review

r=me

> Source/ThirdParty/libwebrtc/ChangeLog:13
> +
> +        Crash logging shows occasional crashes in MergeUVRow_AVX2; the explanation
> +        for these crashes seems to be a mismatch between the size of the libvpx
> +        output frame and the size of the CVPixelBuffer where the converted frame
> +        data is being stored. Add a pre-flight check that will bail out early in
> +        this scenario.

At first I thought this might not be great behavior; but your comment in Radar convinced me. Might be helpful to add that comment in your ChangeLog or in the code.
Comment 5 Geoffrey Garen 2021-03-09 15:24:40 PST
Side note: I think Youenn was looking at a similar crash.
Comment 6 Jer Noble 2021-03-10 09:20:22 PST
<rdar://75183835>
Comment 7 Jer Noble 2021-03-10 09:20:55 PST
Created attachment 422837 [details]
Patch for landing
Comment 8 EWS 2021-03-10 13:56:47 PST
Committed r274237: <https://commits.webkit.org/r274237>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422837 [details].