...
Like https://bugs.webkit.org/show_bug.cgi?id=209189 and https://bugs.webkit.org/show_bug.cgi?id=213292.
Created attachment 422765 [details] Patch
Created attachment 422838 [details] Patch
Comment on attachment 422838 [details] Patch I guess the idea is to remove that logging after investigation. That seems ok. Otherwise, I would go with something like RELEASE_LOG_WITH_LEVEL_IF, pass session IDs as part of the IF, and use Verbose level. And maybe add some test runner API to turn the logging info on a per test basis.
(In reply to youenn fablet from comment #4) > Comment on attachment 422838 [details] > Patch > > I guess the idea is to remove that logging after investigation. > That seems ok. > Otherwise, I would go with something like RELEASE_LOG_WITH_LEVEL_IF, pass > session IDs as part of the IF, and use Verbose level. > > And maybe add some test runner API to turn the logging info on a per test > basis. Yes, let's remove it when tests are fixed: https://bugs.webkit.org/show_bug.cgi?id=223086.
commit-queue failed to commit attachment 422838 [details] to WebKit repository. To retry, please set cq+ flag again.
Created attachment 423006 [details] Patch for landing
Committed r274323: <https://commits.webkit.org/r274323> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423006 [details].
<rdar://problem/75346752>
Comment on attachment 423006 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=423006&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2407 > + return; Fails to call completion handler.
(In reply to Chris Dumez from comment #10) > Comment on attachment 423006 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423006&action=review > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2407 > > + return; > > Fails to call completion handler. Fixed in <https://commits.webkit.org/r274364> to address assertions on the bots.