Bug 222995 - Add some logging to help debug flaky quota tests
Summary: Add some logging to help debug flaky quota tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-09 14:48 PST by Sihui Liu
Modified: 2021-03-12 10:50 PST (History)
4 users (show)

See Also:

Attachments
Patch (29.71 KB, patch)
2021-03-09 14:56 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (29.60 KB, patch)
2021-03-10 09:27 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (29.57 KB, patch)
2021-03-11 19:25 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-03-09 14:48:57 PST 
...
Comment 2 Sihui Liu 2021-03-09 14:56:58 PST 
Created attachment 422765 [details]
Patch
Comment 3 Sihui Liu 2021-03-10 09:27:06 PST 
Created attachment 422838 [details]
Patch
Comment 4 youenn fablet 2021-03-11 11:06:52 PST 
Comment on attachment 422838 [details]
Patch

I guess the idea is to remove that logging after investigation.
That seems ok.
Otherwise, I would go with something like RELEASE_LOG_WITH_LEVEL_IF, pass session IDs as part of the IF, and use Verbose level.

And maybe add some test runner API to turn the logging info on a per test basis.
Comment 5 Sihui Liu 2021-03-11 13:52:52 PST 
(In reply to youenn fablet from comment #4)
> Comment on attachment 422838 [details]
> Patch
> 
> I guess the idea is to remove that logging after investigation.
> That seems ok.
> Otherwise, I would go with something like RELEASE_LOG_WITH_LEVEL_IF, pass
> session IDs as part of the IF, and use Verbose level.
> 
> And maybe add some test runner API to turn the logging info on a per test
> basis.

Yes, let's remove it when tests are fixed: https://bugs.webkit.org/show_bug.cgi?id=223086.
Comment 6 EWS 2021-03-11 14:04:06 PST 
commit-queue failed to commit attachment 422838 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 7 Sihui Liu 2021-03-11 19:25:23 PST 
Created attachment 423006 [details]
Patch for landing
Comment 8 EWS 2021-03-11 20:42:32 PST 
Committed r274323: <https://commits.webkit.org/r274323>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423006 [details].
Comment 9 Radar WebKit Bug Importer 2021-03-11 20:43:17 PST 
<rdar://problem/75346752>
Comment 10 Chris Dumez 2021-03-12 10:47:42 PST 
Comment on attachment 423006 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=423006&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2407
> +        return;

Fails to call completion handler.
Comment 11 Chris Dumez 2021-03-12 10:50:15 PST 
(In reply to Chris Dumez from comment #10)
> Comment on attachment 423006 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423006&action=review
> 
> > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2407
> > +        return;
> 
> Fails to call completion handler.

Fixed in <https://commits.webkit.org/r274364> to address assertions on the bots.