Bug 222984 - [WebIDL] Don't generate setters for global constructor properties
Summary: [WebIDL] Don't generate setters for global constructor properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-09 09:23 PST by Alexey Shvayka
Modified: 2021-03-18 09:48 PDT (History)
9 users (show)

See Also:

Attachments
Patch (232.17 KB, patch)
2021-03-09 09:26 PST, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-03-09 09:23:46 PST 
[WebIDL] Don't generate setters for global constructor properties
Comment 1 Alexey Shvayka 2021-03-09 09:26:30 PST 
Created attachment 422715 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-03-16 10:24:37 PDT 
<rdar://problem/75482675>
Comment 3 EWS 2021-03-18 08:50:47 PDT 
Committed r274647: <https://commits.webkit.org/r274647>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422715 [details].
Comment 4 Alexey Shvayka 2021-03-18 09:48:30 PDT 
Thanks Alex! It's non-trivial to review w/o test case + CustomValue is quite weird. I appreciate it!