Cleanup RenderFlexibleBox

[Rob Buis]

Cleanup RenderFlexibleBox.

[Rob Buis]

Created attachment 422698 [details]
Patch

[Rob Buis]

Created attachment 422705 [details]
Patch

[Rob Buis]

Created attachment 422746 [details]
Patch

[Rob Buis]

Created attachment 422807 [details]
Patch

[Rob Buis]

Created attachment 422912 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 422912 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422912&action=review

Thanks for the cleanup!

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1226
> +            return std::max(childSize, std::min(transferredSize, contentSize));

This is correct from the current API POV, but I think we should review at some point computeMainSizeFromAspectRatioUsing() because it's OK if it returns a nullopt. Right now it isn't possible because we replace it by 0_lu just before returning but I think that is not very precise. Could you add some FIXME so that we don't forget about it?

[Rob Buis]

Created attachment 422924 [details]
Patch

[EWS]

Committed r274284: <https://commits.webkit.org/r274284>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422924 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75320821>