Bug 222960 – [GPU Process] ImageBitmap should release its ImageBuffer in the main thread

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Said Abou-Hallawa]

The ImageBuffer of the ImageBitmap should be deleted on the main thread only since its deletion may require sending messages to the GPUP.

[Said Abou-Hallawa]

Created attachment 422668 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 422668 [details]
Patch

It this covered by tests?

[Said Abou-Hallawa]

Created attachment 422728 [details]
Patch

[Said Abou-Hallawa]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 422668 [details]
> Patch
> 
> It this covered by tests?

imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-in-worker-transfer.html

[Chris Dumez]

Comment on attachment 422728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422728&action=review

> Source/WebCore/html/ImageBitmap.cpp:848
> +        callOnMainThread([imageBuffer = WTFMove(imageBuffer)]() mutable { });

I doubt the mutable and () are needed.

[Simon Fraser (smfr)]

(In reply to Said Abou-Hallawa from comment #4)
> (In reply to Simon Fraser (smfr) from comment #2)
> > Comment on attachment 422668 [details]
> > Patch
> > 
> > It this covered by tests?
> 
> imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/
> createImageBitmap-in-worker-transfer.html

Please note in the changeling.

[Said Abou-Hallawa]

Created attachment 422731 [details]
Patch

[EWS]

Committed r274164: <https://commits.webkit.org/r274164>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422731 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75228853>

[Said Abou-Hallawa]

*** Bug 222879 has been marked as a duplicate of this bug. ***