Bug 222938 - TestWebKitAPI WebKit.HitTestResultNodeHandle does not complete with ENABLE_CONTEXT_MENUS=OFF
Summary: TestWebKitAPI WebKit.HitTestResultNodeHandle does not complete with ENABLE_CO...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephan Szabo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-08 13:22 PST by Stephan Szabo
Modified: 2021-03-08 18:46 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.92 KB, patch)
2021-03-08 15:13 PST, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2021-03-08 13:22:53 PST 
WebKit.HitTestResultNodeHandle uses WKBundlePageSetContextMenuClient to set getContextMenuFromDefaultMenu to send the message to complete the test. However, at least testing on WinCairo and PlayStation, when ENABLE_CONTEXT_MENUS is OFF, that will not happen so the test can't complete.
Comment 1 Stephan Szabo 2021-03-08 15:13:54 PST 
Created attachment 422625 [details]
Patch
Comment 2 Ross Kirsling 2021-03-08 15:51:46 PST 
Comment on attachment 422625 [details]
Patch

r=me
Comment 3 EWS 2021-03-08 18:45:06 PST 
Committed r274128: <https://commits.webkit.org/r274128>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422625 [details].
Comment 4 Radar WebKit Bug Importer 2021-03-08 18:46:20 PST 
<rdar://problem/75198343>