Bug 222937 – Simplify CallbackAggregator in WebsiteDataStore::fetchDataAndApply()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Simplify CallbackAggregator in WebsiteDataStore::fetchDataAndApply().

[Chris Dumez]

Created attachment 422609 [details]
Patch

[Darin Adler]

Comment on attachment 422609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422609&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:432
> +private:

Should indent this 4?

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:441
> +    auto callbackAggregator = adoptRef(new CallbackAggregator(fetchOptions, WTFMove(queue), WTFMove(apply), *this));

Seems like there is a missing * here so we get a Ref<> instead of a RefPtr<>.

[Chris Dumez]

(In reply to Darin Adler from comment #2)
> Comment on attachment 422609 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422609&action=review
> 
> > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:432
> > +private:
> 
> Should indent this 4?
> 
> > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:441
> > +    auto callbackAggregator = adoptRef(new CallbackAggregator(fetchOptions, WTFMove(queue), WTFMove(apply), *this));
> 
> Seems like there is a missing * here so we get a Ref<> instead of a RefPtr<>.

Oh right. We used to not do that to make capture by value convenient in the lambdas. However, Ref<> has a copy-constructor nowadays!

[Chris Dumez]

Created attachment 422646 [details]
Patch

[Chris Dumez]

Created attachment 422649 [details]
Patch

[EWS]

Committed r274130: <https://commits.webkit.org/r274130>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422649 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75199890>