Bug 222934 – Adopt new NSURLSessionConfiguration SPI for connection cache configuration

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ben Nham]

Adopt new NSURLSessionConfiguration SPI for connection cache configuration

[Ben Nham]

Created attachment 422604 [details]
Patch

[Ben Nham]

Created attachment 422611 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/75218970>

[Sam Weinig]

Comment on attachment 422611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422611&action=review

> Source/WebCore/platform/network/cf/ResourceRequestCFNet.h:51
> +    case 0:

Does CFNetwork define these values in constants anywhere?

[Ben Nham]

(In reply to Sam Weinig from comment #4)
> Comment on attachment 422611 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422611&action=review
> 
> > Source/WebCore/platform/network/cf/ResourceRequestCFNet.h:51
> > +    case 0:
> 
> Does CFNetwork define these values in constants anywhere?

No, the user just assigns an arbitrary integer value in the range [0, _connectionCacheNumPriorityLevels) as they please. So basically this SPI allows us to map our five WebKit resource priority levels into five CFNetwork request priority levels. Previously we were mapping our five resource priority levels into four CFNetwork request priority levels to work around the bug described in https://bugs.webkit.org/show_bug.cgi?id=203423.

Also note that this SPI only affects HTTP/1.1 requests. There is a separate path for setting HTTP/2 stream priorities that is actually an API which we already use elsewhere (-[NSURLSessionTask priority]).

[Geoffrey Garen]

Comment on attachment 422611 [details]
Patch

r=me

[EWS]

Committed r274161: <https://commits.webkit.org/r274161>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422611 [details].