Bug 222932 - Multi-column state propagation should follow containing block rules
Summary: Multi-column state propagation should follow containing block rules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on: 222987
Blocks:
  Show dependency treegraph
 
Reported: 2021-03-08 12:28 PST by zalan
Modified: 2021-03-10 09:31 PST (History)
11 users (show)

See Also:


Attachments
Patch (7.97 KB, patch)
2021-03-08 15:01 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (7.93 KB, patch)
2021-03-10 07:04 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-03-08 12:28:59 PST
<rdar://problem/74459411>
Comment 1 zalan 2021-03-08 15:01:25 PST
Created attachment 422622 [details]
Patch
Comment 2 Antti Koivisto 2021-03-09 02:39:25 PST
Comment on attachment 422622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422622&action=review

> Source/WebCore/rendering/RenderObject.cpp:214
> +                // It's ok to only check the fist level containing block (as opposed to the containing block chain) as setFragmentedFlowStateIncludingDescendants is top to down.

typo 'fist'
Comment 3 zalan 2021-03-10 07:04:38 PST
Created attachment 422827 [details]
Patch
Comment 4 EWS 2021-03-10 09:31:51 PST
Committed r274217: <https://commits.webkit.org/r274217>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422827 [details].