Bug 222926 - [Cocoa][GPUP] Enable WebM/Vorbis/Opus in the GPU process
Summary: [Cocoa][GPUP] Enable WebM/Vorbis/Opus in the GPU process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-08 11:45 PST by Jer Noble
Modified: 2021-05-04 09:56 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.49 KB, patch)
2021-03-08 11:49 PST, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (10.63 KB, patch)
2021-03-08 12:31 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-03-08 11:45:24 PST 
[Cocoa][GPUP] Enable WebM/Vorbis/Opus in the GPU process
Comment 1 Jer Noble 2021-03-08 11:49:11 PST 
Created attachment 422595 [details]
Patch
Comment 2 Eric Carlson 2021-03-08 12:10:16 PST 
Comment on attachment 422595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422595&action=review

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:475
> +    send(Messages::GPUProcess::SetWebMParserEnabled(hasEnabledWebMParser), 0);
> +    send(Messages::GPUProcess::SetWebMFormatReaderEnabled(hasEnabledWebMFormatReader), 0);
> +    send(Messages::GPUProcess::SetOpusDecoderEnabled(hasEnabledOpus), 0);
> +    send(Messages::GPUProcess::SetVorbisDecoderEnabled(hasEnabledVorbis), 0);

The messages and methods in GPUProcess.cpp/.h all have compile flags around them, so these need to be guarded too.
Comment 3 Jer Noble 2021-03-08 12:31:21 PST 
Created attachment 422603 [details]
Patch for landing
Comment 4 EWS 2021-03-08 16:15:50 PST 
Committed r274117: <https://commits.webkit.org/r274117>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422603 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-08 16:16:16 PST 
<rdar://problem/75192641>
Comment 6 Alex Christensen 2021-05-04 09:56:25 PDT 
Comment on attachment 422595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422595&action=review

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:447
> +    WebPageGroup::forEach([&] (auto& group) mutable {

Why WebPageGroup?