Bug 222926 – [Cocoa][GPUP] Enable WebM/Vorbis/Opus in the GPU process

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Cocoa][GPUP] Enable WebM/Vorbis/Opus in the GPU process

[Jer Noble]

Created attachment 422595 [details]
Patch

[Eric Carlson]

Comment on attachment 422595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422595&action=review

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:475
> +    send(Messages::GPUProcess::SetWebMParserEnabled(hasEnabledWebMParser), 0);
> +    send(Messages::GPUProcess::SetWebMFormatReaderEnabled(hasEnabledWebMFormatReader), 0);
> +    send(Messages::GPUProcess::SetOpusDecoderEnabled(hasEnabledOpus), 0);
> +    send(Messages::GPUProcess::SetVorbisDecoderEnabled(hasEnabledVorbis), 0);

The messages and methods in GPUProcess.cpp/.h all have compile flags around them, so these need to be guarded too.

[Jer Noble]

Created attachment 422603 [details]
Patch for landing

[EWS]

Committed r274117: <https://commits.webkit.org/r274117>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422603 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75192641>

[Alex Christensen]

Comment on attachment 422595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422595&action=review

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:447
> +    WebPageGroup::forEach([&] (auto& group) mutable {

Why WebPageGroup?