Bug 222925 - [Cocoa] Changes in WebInspectorUI's appearance don't propagate to .effectiveAppearance while docked
Summary: [Cocoa] Changes in WebInspectorUI's appearance don't propagate to .effectiveA...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-08 11:43 PST by BJ Burg
Modified: 2021-03-08 14:10 PST (History)
6 users (show)

See Also:

Attachments
Patch v1.0 (4.14 KB, patch)
2021-03-08 11:48 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2021-03-08 11:43:58 PST 
.
Comment 1 BJ Burg 2021-03-08 11:44:15 PST 
<rdar://71201454>
Comment 2 BJ Burg 2021-03-08 11:48:55 PST 
Created attachment 422594 [details]
Patch v1.0
Comment 3 Devin Rousso 2021-03-08 13:17:51 PST 
Comment on attachment 422594 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=422594&action=review

r=me with one question/concern

> Source/WebKit/UIProcess/Inspector/mac/WebInspectorProxyMac.mm:862
> +    [m_inspectorViewController webView].appearance = platformAppearance;

Does this have any effect on the inspected page when Web Inspector is docked and the developer changes the Appearance setting in the General pane of the Settings Tab?
Comment 4 BJ Burg 2021-03-08 13:50:36 PST 
Comment on attachment 422594 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=422594&action=review

>> Source/WebKit/UIProcess/Inspector/mac/WebInspectorProxyMac.mm:862
>> +    [m_inspectorViewController webView].appearance = platformAppearance;
> 
> Does this have any effect on the inspected page when Web Inspector is docked and the developer changes the Appearance setting in the General pane of the Settings Tab?

It's just for the inspector WebView (m_inspectorPage). The inspected webView will follow the appearance of the client (i.e. Safari) until set otherwise.
Comment 5 EWS 2021-03-08 14:10:10 PST 
Committed r274106: <https://commits.webkit.org/r274106>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422594 [details].