Bug 222920 – Web Inspector: Grid overlay does not adjust for element inside iframes

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Patrick Angle]

Grid overlay do not currently account for being inside an iframe when drawing, so gridlines can appear offset from the grid itself.

[Radar WebKit Bug Importer]

<rdar://problem/75192511>

[Patrick Angle]

Created attachment 423209 [details]
Patch v1.0

[Patrick Angle]

Created attachment 423210 [details]
Video of Patch v1.0

[Blaze Burg]

Comment on attachment 423209 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=423209&action=review

Overlay changes look correct, but I have concerns about changing ScrollView/FrameView helpers.

> Source/WebCore/page/FrameView.cpp:4791
> +

Nit: remove extra newline or inline the entire expression.

> Source/WebCore/platform/ScrollView.cpp:894
> +    return point - toFloatSize(documentScrollPositionRelativeToViewOrigin());

Please don't change this here, it's used elsewhere and I have no confidence that it's okay to do this in all cases.

Alternatively, add an optional argument that opts into the new behavior, while leaving existing callsites and behavior unchanged.

> Source/WebCore/platform/Widget.cpp:266
> +    if (const ScrollView* parentScrollView = parent())

Ditto above comment about changing behaviors.

[Patrick Angle]

Created attachment 423247 [details]
Patch v1.1 - Maintain existing integer precision paths for compatibility

[Patrick Angle]

Created attachment 423254 [details]
Patch v1.2 - Use enum instead of bool for precision parameter

[Patrick Angle]

Created attachment 423261 [details]
Patch v1.3 - Redux of v1.0 for EWS

[EWS]

Committed r274464: <https://commits.webkit.org/r274464>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423261 [details].