Bug 222901 - [GStreamer][WebRTC] VideoEncoder still doesn't comply with WebKit style
Summary: [GStreamer][WebRTC] VideoEncoder still doesn't comply with WebKit style
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
Keywords: InRadar
Depends on:
Reported: 2021-03-08 03:07 PST by Philippe Normand
Modified: 2021-03-09 08:54 PST (History)
12 users (show)

See Also:

Patch (26.11 KB, patch)
2021-03-08 04:06 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (26.06 KB, patch)
2021-03-09 08:23 PST, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-03-08 03:07:35 PST
Bug 218748 was incomplete, as it didn't update the file filter in the coding style checker.
Comment 1 Philippe Normand 2021-03-08 04:06:21 PST
Created attachment 422553 [details]
Comment 2 Xabier Rodríguez Calvar 2021-03-08 10:36:43 PST
Comment on attachment 422553 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=422553&action=review

> Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp:65
> +        SetupFunc setupEncoder, const char* bitratePropertyName, SetBitrateFunc setBitrate, const char* keyframeIntervalPropertyName)

SetupFunc&& and SetBitrateFunc&&
Comment 3 Philippe Normand 2021-03-09 08:23:56 PST
Created attachment 422699 [details]
Comment 4 EWS 2021-03-09 08:53:23 PST
Committed r274149: <https://commits.webkit.org/r274149>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422699 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-09 08:54:25 PST