Bug 222859 - Metal-ANGLE can ASSERT because MTL signal event code is compiled out
Summary: Metal-ANGLE can ASSERT because MTL signal event code is compiled out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-06 05:54 PST by Dean Jackson
Modified: 2021-03-18 12:07 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.11 KB, patch)
2021-03-06 06:02 PST, Dean Jackson 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2021-03-06 05:54:55 PST 
Metal-ANGLE can ASSERT because MTL signal event code is compiled out
Comment 1 Radar WebKit Bug Importer 2021-03-06 05:56:33 PST 
<rdar://problem/75132180>
Comment 2 Dean Jackson 2021-03-06 06:02:31 PST 
Created attachment 422487 [details]
Patch
Comment 3 EWS Watchlist 2021-03-08 04:26:08 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Kenneth Russell 2021-03-08 16:50:08 PST 
Comment on attachment 422487 [details]
Patch

Looks good. I vaguely remember this fix being done elsewhere (in the previous attempt to upstream the new Metal backend to ANGLE?) but sounds fine to get this fix in now. r+
Comment 5 Dean Jackson 2021-03-17 13:34:26 PDT 
Landed as part of r274547
Comment 6 Dean Jackson 2021-03-18 12:07:54 PDT 
Committed r274660 (235485@main): <https://commits.webkit.org/235485@main>