Bug 222857 - [perf dashboard] Modernize MeasurementSet
Summary: [perf dashboard] Modernize MeasurementSet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-06 02:23 PST by Ryosuke Niwa
Modified: 2021-03-06 16:26 PST (History)
5 users (show)

See Also:

Attachments
Cleanup (23.54 KB, patch)
2021-03-06 02:36 PST, Ryosuke Niwa 		dewei_zhu: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-03-06 02:23:08 PST 
Modernize MeasurementSet.
Comment 1 Ryosuke Niwa 2021-03-06 02:36:22 PST 
Created attachment 422480 [details]
Cleanup
Comment 2 dewei_zhu 2021-03-06 15:46:11 PST 
Comment on attachment 422480 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=422480&action=review

> Websites/perf.webkit.org/public/v3/models/measurement-set.js:103
> +        let suffix = clusterEndTime ? '-' + +clusterEndTime : '';

Use `const`?
Comment 3 dewei_zhu 2021-03-06 15:46:21 PST 
r=me
Comment 4 Ryosuke Niwa 2021-03-06 16:08:11 PST 
(In reply to dewei_zhu from comment #2)
> Comment on attachment 422480 [details]
> Cleanup
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422480&action=review
> 
> > Websites/perf.webkit.org/public/v3/models/measurement-set.js:103
> > +        let suffix = clusterEndTime ? '-' + +clusterEndTime : '';
> 
> Use `const`?

Good point!
Comment 5 Ryosuke Niwa 2021-03-06 16:25:03 PST 
Committed r274043 (234979@main): <https://commits.webkit.org/234979@main>
Comment 6 Radar WebKit Bug Importer 2021-03-06 16:26:14 PST 
<rdar://problem/75137842>