Bug 22284 - Incorrect assert caused by uninitialized variable in NetworkStateNotifier
Summary: Incorrect assert caused by uninitialized variable in NetworkStateNotifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Qt, Wx
Depends on:
Blocks:
 
Reported: 2008-11-15 13:22 PST by Kevin Ollivier
Modified: 2008-11-15 15:39 PST (History)
0 users

See Also:


Attachments
Fix that initializes m_networkStateChangedFunction (991 bytes, patch)
2008-11-15 13:23 PST, Kevin Ollivier
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Ollivier 2008-11-15 13:22:44 PST
If m_networkStateChangedFunction is not initialized to null, then the assert checking that it wasn't set will fail even though it hasn't been set. This has been fixed already for Safari on Win/Mac and Chrome, but the issue exists for the fallback implementation.
Comment 1 Kevin Ollivier 2008-11-15 13:23:52 PST
Created attachment 25192 [details]
Fix that initializes m_networkStateChangedFunction
Comment 2 Kevin Ollivier 2008-11-15 15:39:56 PST
Landed in r38436, thanks!