Bug 222836 - [GPUP] Move GPUProcess WebGL to Experimental Feature
Summary: [GPUP] Move GPUProcess WebGL to Experimental Feature
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
Keywords: InRadar
Depends on:
Blocks: webglgpup
  Show dependency treegraph
Reported: 2021-03-05 15:24 PST by Jon Lee
Modified: 2021-05-03 23:34 PDT (History)
9 users (show)

See Also:

EWS test (1.25 KB, patch)
2021-03-05 15:29 PST, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (17.40 KB, patch)
2021-03-18 04:36 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (6.09 KB, patch)
2021-05-03 02:58 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2021-03-05 15:24:48 PST
[GPUP] Enable WebGL in layout tests by default
Comment 1 Jon Lee 2021-03-05 15:25:01 PST
Comment 2 Jon Lee 2021-03-05 15:29:37 PST
Created attachment 422439 [details]
EWS test
Comment 3 Peng Liu 2021-03-17 11:22:03 PDT
Comment on attachment 422439 [details]
EWS test

View in context: https://bugs.webkit.org/attachment.cgi?id=422439&action=review

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:174
> +    return true;

This will enable the feature by default, not only for WKTR.
Comment 4 Kimmo Kinnunen 2021-03-17 11:23:03 PDT
Yeah, I'll revise (change the yamls)
Comment 5 Kimmo Kinnunen 2021-03-18 04:36:23 PDT
Created attachment 423586 [details]
Comment 6 Peng Liu 2021-03-22 09:41:38 PDT
Comment on attachment 423586 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=423586&action=review

> Source/WTF/ChangeLog:10
> +        external in order to make WebGL use GPU process in

Comment 7 Jon Lee 2021-03-29 11:22:33 PDT
Can we revise this patch to move the flag to experimental, but keep it OFF on layout tests?
Comment 8 Kimmo Kinnunen 2021-05-03 02:58:47 PDT
Created attachment 427547 [details]
Comment 9 Brent Fulgham 2021-05-03 17:26:29 PDT
Comment on attachment 427547 [details]

Comment 10 EWS 2021-05-03 23:34:03 PDT
Committed r276948 (237281@main): <https://commits.webkit.org/237281@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427547 [details].