Bug 222827 - [webkitscmpy] Add repository_id
Summary: [webkitscmpy] Add repository_id
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-05 14:05 PST by Jonathan Bedard
Modified: 2021-03-08 10:09 PST (History)
4 users (show)

See Also:

Attachments
Patch (17.06 KB, patch)
2021-03-05 14:11 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (17.04 KB, patch)
2021-03-08 09:29 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-03-05 14:05:31 PST 
Make webkitscmpy's representation of a commit compatible with what the results database uses.
Comment 1 Radar WebKit Bug Importer 2021-03-05 14:05:56 PST 
<rdar://problem/75111000>
Comment 2 Jonathan Bedard 2021-03-05 14:11:28 PST 
Created attachment 422418 [details]
Patch
Comment 3 dewei_zhu 2021-03-05 17:20:57 PST 
Comment on attachment 422418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422418&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py:43
> +    def __init__(self, dev_branches=None, prod_branches=None, contributors=None, id=None):

Worth mention that id is a built-in, but seems a reasonable variable name here.
Comment 4 Jonathan Bedard 2021-03-08 09:15:00 PST 
(In reply to dewei_zhu from comment #3)
> Comment on attachment 422418 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422418&action=review
> 
> > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py:43
> > +    def __init__(self, dev_branches=None, prod_branches=None, contributors=None, id=None):
> 
> Worth mention that id is a built-in, but seems a reasonable variable name
> here.

Yes, I usually try to avoid using built-ins, but this seems like the right variable name.
Comment 5 Jonathan Bedard 2021-03-08 09:29:23 PST 
Created attachment 422576 [details]
Patch for landing
Comment 6 EWS 2021-03-08 10:09:36 PST 
Committed r274080: <https://commits.webkit.org/r274080>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422576 [details].