Bug 222821 - [LFC][IFC] Provide a better estimate on the number of inline level boxes per line for LineBox.
Summary: [LFC][IFC] Provide a better estimate on the number of inline level boxes per ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-05 13:39 PST by zalan
Modified: 2021-03-06 18:39 PST (History)
5 users (show)

See Also:


Attachments
Patch (10.21 KB, patch)
2021-03-05 13:44 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (10.25 KB, patch)
2021-03-06 11:33 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (10.25 KB, patch)
2021-03-06 15:34 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-03-05 13:39:51 PST
try to count them.
Comment 1 zalan 2021-03-05 13:44:53 PST
Created attachment 422409 [details]
Patch
Comment 2 Antti Koivisto 2021-03-06 05:51:40 PST
Comment on attachment 422409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422409&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.h:62
> +        size_t inlineLevelBoxCount { 0 }; // Note that inline boxes spanning multiple lines may not be included in here.

esitemated/approximateInlineLevelBoxCount or similar?
Comment 3 zalan 2021-03-06 11:33:57 PST
Created attachment 422501 [details]
Patch
Comment 4 zalan 2021-03-06 15:34:00 PST
Created attachment 422510 [details]
Patch
Comment 5 EWS 2021-03-06 18:38:04 PST
Committed r274048: <https://commits.webkit.org/r274048>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422510 [details].
Comment 6 Radar WebKit Bug Importer 2021-03-06 18:39:14 PST
<rdar://problem/75138898>