Bug 222810 - [Payment Request] if `requestShipping: false` then we should not show any `PaymentShippingOption` in the Apple Pay sheet
Summary: [Payment Request] if `requestShipping: false` then we should not show any `Pa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-05 10:48 PST by Devin Rousso
Modified: 2021-03-05 15:29 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.10 KB, patch)
2021-03-05 10:54 PST, Devin Rousso
thorton: review+
drousso: commit-queue-
Details | Formatted Diff | Diff
Patch (2.29 KB, patch)
2021-03-05 12:43 PST, Devin Rousso
drousso: commit-queue+
Details | Formatted Diff | Diff
Patch (11.11 KB, patch)
2021-03-05 13:42 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (18.52 KB, patch)
2021-03-05 13:56 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-03-05 10:48:33 PST
.
Comment 1 Devin Rousso 2021-03-05 10:48:52 PST
<rdar://problem/74550889>
Comment 2 Devin Rousso 2021-03-05 10:54:04 PST
Created attachment 422384 [details]
Patch
Comment 3 Devin Rousso 2021-03-05 12:11:06 PST
Comment on attachment 422384 [details]
Patch

After talking with @Andy Estes, I think I want/need to tweak this to be more spec compatible.
Comment 4 Devin Rousso 2021-03-05 12:43:43 PST
Created attachment 422396 [details]
Patch
Comment 5 Devin Rousso 2021-03-05 13:42:46 PST
Created attachment 422408 [details]
Patch
Comment 6 Devin Rousso 2021-03-05 13:56:59 PST
Created attachment 422413 [details]
Patch
Comment 7 EWS 2021-03-05 15:29:07 PST
Committed r274012: <https://commits.webkit.org/r274012>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422413 [details].