Bug 222809 - Regression(r268097): WKWebView.URL is nil in the processDidTerminate delegate
Summary: Regression(r268097): WKWebView.URL is nil in the processDidTerminate delegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 217407
  Show dependency tree / graph
 
Reported: 2021-03-05 10:38 PST by Chris Dumez
Modified: 2021-03-05 12:54 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.82 KB, patch)
2021-03-05 10:47 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.45 KB, patch)
2021-03-05 10:58 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-03-05 10:38:10 PST 
WKWebView.URL is nil in the processDidTerminate delegate since r268097.
Comment 1 Chris Dumez 2021-03-05 10:47:39 PST 
Created attachment 422383 [details]
Patch
Comment 2 Michael Catanzaro 2021-03-05 10:55:00 PST 
Comment on attachment 422383 [details]
Patch

Nice test.
Comment 3 Michael Catanzaro 2021-03-05 10:55:29 PST 
One style error:

ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:372:  This { should be at the end of the previous line  [whitespace/braces] [4]
Comment 4 Chris Dumez 2021-03-05 10:58:43 PST 
Created attachment 422386 [details]
Patch
Comment 5 Chris Dumez 2021-03-05 12:53:53 PST 
Comment on attachment 422386 [details]
Patch

Clearing flags on attachment: 422386

Committed r273997 (234941@main): <https://commits.webkit.org/234941@main>
Comment 6 Chris Dumez 2021-03-05 12:53:56 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2021-03-05 12:54:22 PST 
<rdar://problem/75107755>