Bug 222803 - GLib JSC API headers should only include other GLib JSC API headers
Summary: GLib JSC API headers should only include other GLib JSC API headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-05 07:48 PST by Don Olmstead
Modified: 2021-03-09 23:37 PST (History)
16 users (show)

See Also:

Attachments
WIP Patch (9.69 KB, patch)
2021-03-09 08:35 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (9.69 KB, patch)
2021-03-09 08:54 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (12.66 KB, patch)
2021-03-09 09:45 PST, Don Olmstead 		mcatanzaro: review+
Details | Formatted Diff | Diff
Patch (18.75 KB, patch)
2021-03-09 11:00 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.08 KB, patch)
2021-03-09 13:14 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (19.50 KB, patch)
2021-03-09 13:14 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (21.83 KB, patch)
2021-03-09 20:41 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (21.87 KB, patch)
2021-03-09 21:43 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (22.42 KB, patch)
2021-03-09 22:15 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (22.59 KB, patch)
2021-03-09 22:22 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (22.67 KB, patch)
2021-03-09 22:37 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-03-05 07:48:53 PST 
A number of private GLib JSC headers are directly including JavaScriptCore headers. They are being consumed as <jsc/JSCFooPrivate.h> in the InjectedBundle API code for GLib ports. However there are JavaScriptCore headers in there that are included as "Foo.h" which is wrong because when building WebKit that header needs to be included as <JavaScriptCore/Foo.h>.

The fix should be forward declaring any JavaScriptCore specific constructs and only including files within API/glib relatively.
Comment 1 Don Olmstead 2021-03-09 08:35:25 PST Comment hidden (obsolete)
Comment 2 EWS Watchlist 2021-03-09 08:36:12 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2021-03-09 08:54:04 PST Comment hidden (obsolete)
Comment 4 Don Olmstead 2021-03-09 09:45:49 PST Comment hidden (obsolete)
Comment 5 Michael Catanzaro 2021-03-09 09:52:02 PST 
Comment on attachment 422720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422720&action=review

> Source/JavaScriptCore/PlatformGTK.cmake:73
> +            --warn-error

I like.
Comment 6 Don Olmstead 2021-03-09 11:00:53 PST 
Created attachment 422729 [details]
Patch
Comment 7 Don Olmstead 2021-03-09 13:14:20 PST Comment hidden (obsolete)
Comment 8 Don Olmstead 2021-03-09 13:14:50 PST Comment hidden (obsolete)
Comment 9 Don Olmstead 2021-03-09 20:41:04 PST Comment hidden (obsolete)
Comment 10 Don Olmstead 2021-03-09 21:43:48 PST Comment hidden (obsolete)
Comment 11 Don Olmstead 2021-03-09 22:15:32 PST Comment hidden (obsolete)
Comment 12 Don Olmstead 2021-03-09 22:22:03 PST Comment hidden (obsolete)
Comment 13 Don Olmstead 2021-03-09 22:37:15 PST 
Created attachment 422803 [details]
Patch
Comment 14 EWS 2021-03-09 23:36:32 PST 
Committed r274201: <https://commits.webkit.org/r274201>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422803 [details].
Comment 15 Radar WebKit Bug Importer 2021-03-09 23:37:16 PST 
<rdar://problem/75252648>