Bug 222797 - [GTK] Clang warnings in MiniBrowser build
Summary: [GTK] Clang warnings in MiniBrowser build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-05 04:05 PST by Philippe Normand
Modified: 2021-03-05 05:15 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.72 KB, patch)
2021-03-05 04:07 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-03-05 04:05:41 PST 
[19/73] Building C object Tools/MiniBrowser/gtk/CMakeFiles/MiniBrowser.dir/BrowserCellRendererVariant.c.o
../../Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c:296:6: warning: expression result unused [-Wunused-value]
    ((__typeof__ (renderer->toggleRenderer)) (g_object_ref_sink) (renderer->toggleRenderer));
     ^                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c:302:6: warning: expression result unused [-Wunused-value]
    ((__typeof__ (renderer->textRenderer)) (g_object_ref_sink) (renderer->textRenderer));
     ^                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
[21/73] Building C object Tools/MiniBrowser/gtk/CMakeFiles/MiniBrowser.dir/BrowserTab.c.o
../../Tools/MiniBrowser/gtk/BrowserTab.c:432:6: warning: expression result unused [-Wunused-value]
    ((__typeof__ (request)) (g_object_ref) (request));
     ^                      ~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Comment 1 Philippe Normand 2021-03-05 04:07:35 PST 
Created attachment 422361 [details]
Patch
Comment 2 EWS 2021-03-05 05:15:31 PST 
Committed r273963: <https://commits.webkit.org/r273963>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422361 [details].