Bug 222796 - Split WebXR features into enabledFeatures, supportedFeatures and requestedFeatures
Summary: Split WebXR features into enabledFeatures, supportedFeatures and requestedFea...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Imanol Fernandez
URL:
Keywords:
Depends on:
Blocks: 208988
  Show dependency tree / graph
 
Reported: 2021-03-05 03:57 PST by Imanol Fernandez
Modified: 2021-03-15 06:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (20.79 KB, patch)
2021-03-05 05:21 PST, Imanol Fernandez 		no flags Details | Formatted Diff | Diff
Patch for landing (24.42 KB, patch)
2021-03-15 05:30 PDT, Imanol Fernandez 		no flags Details | Formatted Diff | Diff
Patch for landing (24.36 KB, patch)
2021-03-15 05:33 PDT, Imanol Fernandez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Imanol Fernandez 2021-03-05 03:57:33 PST 
Currently enabledFeatures array is used both for checking supported and enabled features. This is causing some tests to fail: e.g. Test that reference spaces that aren't default features are rejected when not requested as a feature.
Comment 1 Imanol Fernandez 2021-03-05 05:21:15 PST 
Created attachment 422367 [details]
Patch
Comment 2 Imanol Fernandez 2021-03-05 08:12:32 PST 
Comment on attachment 422367 [details]
Patch

The spec was a bit confusing in the steps to check if a reference space is supported. I opened this related issue:
https://github.com/immersive-web/webxr/issues/1178
Comment 3 Sergio Villar Senin 2021-03-15 04:11:13 PDT 
Comment on attachment 422367 [details]
Patch

Awesome! Please do also consider renaming ListOfEnabledFeatures to some other thing like ListOfFeatures or FeatureList or the like as we're know dealing with different lists.
Comment 4 Imanol Fernandez 2021-03-15 05:30:45 PDT 
Created attachment 423159 [details]
Patch for landing
Comment 5 EWS 2021-03-15 05:31:13 PDT 
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 6 Imanol Fernandez 2021-03-15 05:33:39 PDT 
Created attachment 423160 [details]
Patch for landing
Comment 7 EWS 2021-03-15 06:00:41 PDT 
Committed r274416: <https://commits.webkit.org/r274416>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423160 [details].