Bug 22279 – CSSMutableStyleDeclaration can be moved with memcpy

• Status: RESOLVED
• Resolution: WONTFIX
• Component: CSS

[George Staikos]

For efficiency, enable memcpy for copy of CSSMutableStyleDeclaration.

[George Staikos]

Created attachment 25185 [details]
patch to enable canMoveWithMemcpy

[Alexey Proskuryakov]

Could you please give some numbers for the performance improvement you are seeing?

The ChangeLog shouldn't say it's safe to copy with memcpy - it is not, but you are only enabling moves. That looks correct to me (I'm not an expert on CSS code though), but I'm worried that this change may make others introduce subtle bugs later. 

[Yong Li]

This change should be safe as long as the object address is neither directly nor indirectly used in copy constructor. For our profiling data, Vector::resize takes unexpectedly long time for CSSMutableStyleDeclaration and ResourceResponse. We make a conclusion that copy constructor and destructor are called too many time unnecessarily. We're very busy currently. We will get more accurate performance tracking data, and come back to you later when we get time.

[Yong Li]

Sorry, I have to correct my last reply. Using memcpy is risky for sure. If any member's address is referenced by another member, do memcpy() upon that object or parent objects can result crash. For example, DeprecatedString, Vector with inline buffer, and any object that contains them.

So we would redraw the request.

[Yong Li]

(In reply to comment #4)
> Sorry, I have to correct my last reply. Using memcpy is risky for sure. If any
> member's address is referenced by another member, do memcpy() upon that object
> or parent objects can result crash. For example, DeprecatedString, Vector with
> inline buffer, and any object that contains them.
> 
> So we would redraw the request.
> 

sorry, I mean withdraw

[Geoffrey Garen]

Comment on attachment 25185 [details]
patch to enable canMoveWithMemcpy

Clearing review flag, based on Yong's comment. Should we close this bug?

[George Staikos]

Decided not to do it.