Bug 222779 - [WASM-Function-References] Update ref.func to produce (ref $t)
Summary: [WASM-Function-References] Update ref.func to produce (ref $t)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 247393
  Show dependency tree / graph
 
Reported: 2021-03-04 22:05 PST by Dmitry
Modified: 2022-11-02 17:08 PDT (History)
8 users (show)

See Also:

Attachments
Patch (25.64 KB, patch)
2021-03-04 22:11 PST, Dmitry 		no flags Details | Formatted Diff | Diff
Patch (25.64 KB, patch)
2021-03-05 01:14 PST, Dmitry 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (25.71 KB, patch)
2021-03-05 01:58 PST, Dmitry 		no flags Details | Formatted Diff | Diff
Patch (27.59 KB, patch)
2021-03-05 02:31 PST, Dmitry 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry 2021-03-04 22:05:48 PST 
[WASM-Function-References] Update ref.func to produce (ref $t)
Comment 1 Dmitry 2021-03-04 22:11:28 PST 
Created attachment 422337 [details]
Patch
Comment 2 EWS Watchlist 2021-03-04 22:12:29 PST 
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Comment 3 Yusuke Suzuki 2021-03-05 00:52:19 PST 
Comment on attachment 422337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422337&action=review

r=me with comments.

> Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:217
> +    uint64_t index;

Use SignatureIndex instead.
Comment 4 Dmitry 2021-03-05 01:12:11 PST 
Using SignatureIndex will create a cycle dependency:
WasmSignature.h includes WasmOps.h that includes WasmSignature.h

But I did the "forward declaration" of SignatureIndex in WasmOps.h so this should work well.
Comment 5 Dmitry 2021-03-05 01:14:30 PST 
Created attachment 422348 [details]
Patch
Comment 6 Dmitry 2021-03-05 01:58:27 PST 
Created attachment 422354 [details]
Patch
Comment 7 Dmitry 2021-03-05 02:31:42 PST 
Created attachment 422358 [details]
Patch
Comment 8 Yusuke Suzuki 2021-03-05 03:45:00 PST 
Comment on attachment 422358 [details]
Patch

r=me
Comment 9 EWS 2021-03-05 04:16:54 PST 
Committed r273962: <https://commits.webkit.org/r273962>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422358 [details].
Comment 10 Radar WebKit Bug Importer 2021-03-05 04:17:18 PST 
<rdar://problem/75089479>