Bug 222778 - Add internal preference to disable HTTPS upgrade
Summary: Add internal preference to disable HTTPS upgrade
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-04 21:19 PST by Alex Christensen
Modified: 2021-03-08 10:06 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.41 KB, patch)
2021-03-04 21:22 PST, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-03-04 21:19:37 PST 
Add internal preference to disable HTTPS upgrade
Comment 1 Alex Christensen 2021-03-04 21:22:29 PST 
Created attachment 422335 [details]
Patch
Comment 2 EWS 2021-03-04 23:05:53 PST 
Committed r273950: <https://commits.webkit.org/r273950>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422335 [details].
Comment 3 Radar WebKit Bug Importer 2021-03-04 23:06:16 PST 
<rdar://problem/75080279>
Comment 4 Simon Fraser (smfr) 2021-03-08 10:05:05 PST 
This isn't how preferences normally work.
Comment 5 Simon Fraser (smfr) 2021-03-08 10:06:00 PST 
The right way do use the configuration and preferences here is to have the configuration option feed into a preference (and setting in WebCore). So Page::m_httpsUpgradeEnabled should not exist; that should just be a Setting.