Bug 222776 - Don't open a new window in MiniBrowser if already opening a file from the command line
Summary: Don't open a new window in MiniBrowser if already opening a file from the com...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-04 20:07 PST by Cameron McCormack (:heycam)
Modified: 2021-03-05 12:01 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.42 KB, patch)
2021-03-04 20:09 PST, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-03-04 20:07:24 PST 
Don't open a new window in MiniBrowser if already opening a file from the command line
Comment 1 Cameron McCormack (:heycam) 2021-03-04 20:09:18 PST 
Created attachment 422327 [details]
Patch
Comment 2 Dean Jackson 2021-03-05 09:01:42 PST 
Comment on attachment 422327 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422327&action=review

> Tools/MiniBrowser/mac/AppDelegate.h:41
> +    bool _openNewWindowAtStartup;

It doesn't matter, but ObjC usually uses BOOL.

> Tools/MiniBrowser/mac/AppDelegate.m:75
> +        _openNewWindowAtStartup = true;

... making this YES.

> Tools/MiniBrowser/mac/AppDelegate.m:271
> +    _openNewWindowAtStartup = false;

... and this NO.
Comment 3 EWS 2021-03-05 09:26:49 PST 
commit-queue failed to commit attachment 422327 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 4 EWS 2021-03-05 10:37:55 PST 
commit-queue failed to commit attachment 422327 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 5 EWS 2021-03-05 10:45:08 PST 
commit-queue failed to commit attachment 422327 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 6 EWS 2021-03-05 12:00:15 PST 
Committed r273993: <https://commits.webkit.org/r273993>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422327 [details].
Comment 7 Radar WebKit Bug Importer 2021-03-05 12:01:35 PST 
<rdar://problem/75105616>