RESOLVED FIXED222776
Don't open a new window in MiniBrowser if already opening a file from the command line 
https://bugs.webkit.org/show_bug.cgi?id=222776
Summary Don't open a new window in MiniBrowser if already opening a file from the com...
Cameron McCormack (:heycam)
Reported 2021-03-04 20:07:24 PST
Don't open a new window in MiniBrowser if already opening a file from the command line
Attachments
Patch (2.42 KB, patch)
2021-03-04 20:09 PST, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-03-04 20:09:18 PST
Created attachment 422327 [details] Patch
Dean Jackson
Comment 2 2021-03-05 09:01:42 PST
Comment on attachment 422327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422327&action=review > Tools/MiniBrowser/mac/AppDelegate.h:41 > + bool _openNewWindowAtStartup; It doesn't matter, but ObjC usually uses BOOL. > Tools/MiniBrowser/mac/AppDelegate.m:75 > + _openNewWindowAtStartup = true; ... making this YES. > Tools/MiniBrowser/mac/AppDelegate.m:271 > + _openNewWindowAtStartup = false; ... and this NO.
EWS
Comment 3 2021-03-05 09:26:49 PST
commit-queue failed to commit attachment 422327 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 4 2021-03-05 10:37:55 PST
commit-queue failed to commit attachment 422327 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 5 2021-03-05 10:45:08 PST
commit-queue failed to commit attachment 422327 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 6 2021-03-05 12:00:15 PST
Committed r273993: <https://commits.webkit.org/r273993> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422327 [details].
Radar WebKit Bug Importer
Comment 7 2021-03-05 12:01:35 PST
<rdar://problem/75105616>
Note You need to log in before you can comment on or make changes to this bug.