Bug 222771 - [WinCairo] Builds with ENABLE_CONTEXT_MENUS=OFF fail
Summary: [WinCairo] Builds with ENABLE_CONTEXT_MENUS=OFF fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephan Szabo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-04 17:00 PST by Stephan Szabo
Modified: 2021-03-08 12:10 PST (History)
2 users (show)

See Also:


Attachments
Patch (6.43 KB, patch)
2021-03-08 10:13 PST, Stephan Szabo
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.43 KB, patch)
2021-03-08 10:28 PST, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2021-03-04 17:00:35 PST
While looking at a problem with a TestWebKit test that times out if ENABLE_CONTEXT_MENUS is off (on PlayStation), I noticed that there are a bunch of compilation errors trying to build WinCairo with the flag turned off which seems bad.
Comment 1 Stephan Szabo 2021-03-08 10:13:33 PST
Created attachment 422580 [details]
Patch
Comment 2 Stephan Szabo 2021-03-08 10:28:34 PST
Created attachment 422582 [details]
Patch
Comment 3 EWS 2021-03-08 12:09:21 PST
Committed r274089: <https://commits.webkit.org/r274089>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422582 [details].
Comment 4 Radar WebKit Bug Importer 2021-03-08 12:10:16 PST
<rdar://problem/75181469>