Bug 222749 – [ macOs Wk1 ] http/wpt/filereader/filereader-stop.html is a flakey text failure

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Robert Jenner]

http/wpt/filereader/filereader-stop.html

is a flakey text failure in macOS debug and release in Wk1. 

HISTORY URL:
https://results.webkit.org/?suite=layout-tests&test=http%2Fwpt%2Ffilereader%2Ffilereader-stop.html&platform=mac

DIFF URL:
https://build.webkit.org/results/Apple-Catalina-Release-WK1-Tests/r273891%20(760)/http/wpt/filereader/filereader-stop-pretty-diff.html

DIFF TEXT:
--- /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/http/wpt/filereader/filereader-stop-expected.txt
+++ /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/http/wpt/filereader/filereader-stop-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: Error: assert_unreached: load Reached unreachable code
 
 PASS Make sure events are not fired for stopped readers

[Radar WebKit Bug Importer]

<rdar://problem/75045013>

[Robert Jenner]

Created attachment 422258 [details]
222749-Crashlog

[Robert Jenner]

This is a new test that appears to be flakey text failing in Catalina and Big Sur in Wk1 since it was introduced.

I was able to reproduce a crash at tip of tree with the following test:

run-webkit-test http/wpt/filereader/filereader-stop.html --iterations 100 -f -1

Crash received was:
Process:               DumpRenderTree [97890]
Path:                  /Volumes/VOLUME/*/DumpRenderTree
Identifier:            DumpRenderTree
Version:               0
Code Type:             X86-64 (Native)
Parent Process:        Python [97668]
Responsible:           iTerm2 [1092]
User ID:               501

Date/Time:             2021-03-04 10:46:38.779 -0800
OS Version:            macOS 11.3 (20E175)
Report Version:        12
Bridge OS Version:     5.3 (18P4518b)
Anonymous UUID:        3BACBEA7-EFA8-915D-2B89-E1106E331002

Sleep/Wake UUID:       1CDC448B-8A6C-4521-B42B-DB3795C20553

Time Awake Since Boot: 30000 seconds
Time Since Wake:       7000 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BREAKPOINT (SIGTRAP)
Exception Codes:       0x0000000000000002, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Trace/BPT trap: 5
Termination Reason:    Namespace SIGNAL, Code 0x5
Terminating Process:   exc handler [97890]

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x00000001073ed5b3 WTFCrashWithInfo(int, char const*, char const*, int) + 19
1   com.apple.WebCore             	0x00000001087e1af6 WebCore::FileReader::fireEvent(WTF::AtomString const&) + 486
2   com.apple.WebCore             	0x00000001087e79de WTF::Detail::CallableWrapper<WebCore::FileReader::didFail(WebCore::ExceptionCode)::$_15, void>::call() + 206
3   com.apple.WebCore             	0x00000001087e7ff6 WTF::Detail::CallableWrapper<WebCore::FileReader::enqueueTask(WTF::Function<void ()>&&)::$_16, void>::call() + 390
4   com.apple.WebCore             	0x000000010865e7e5 WebCore::EventLoop::run() + 197
5   com.apple.WebCore             	0x00000001086d5d51 WebCore::WindowEventLoop::didReachTimeToRun() + 17
6   com.apple.WebCore             	0x0000000108d1d7e6 WTF::Detail::CallableWrapper<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0, void>::call() + 198
7   com.apple.WebCore             	0x00000001071cdb0f WebCore::timerFired(__CFRunLoopTimer*, void*) + 31
8   com.apple.CoreFoundation      	0x00007fff2049c129 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
9   com.apple.CoreFoundation      	0x00007fff2049bc1d __CFRunLoopDoTimer + 927
10  com.apple.CoreFoundation      	0x00007fff2049b77a __CFRunLoopDoTimers + 307
11  com.apple.CoreFoundation      	0x00007fff20481dc3 __CFRunLoopRun + 1988
12  com.apple.CoreFoundation      	0x00007fff20480f2c CFRunLoopRunSpecific + 563
13  DumpRenderTree                	0x0000000103c2e1d4 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 5541
14  DumpRenderTree                	0x0000000103c2c752 dumpRenderTree(int, char const**) + 2731
15  DumpRenderTree                	0x0000000103c2ec14 DumpRenderTreeMain(int, char const**) + 397
16  libdyld.dylib                 	0x00007fff203a5e6d start + 1


I have attached the entire crashlog file to this bug as well.

[youenn fablet]

Created attachment 422366 [details]
Patch

[youenn fablet]

(In reply to Robert Jenner from comment #2)
> Created attachment 422258 [details]
> 222749-Crashlog

@Robert, I am not able to reproduce the crash.
Can you still repro it with ToT?

[EWS]

Committed r274468: <https://commits.webkit.org/r274468>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422366 [details].