RESOLVED FIXED 222743
[iOS] Add support for a new image-extraction-related responder action 
https://bugs.webkit.org/show_bug.cgi?id=222743
Summary [iOS] Add support for a new image-extraction-related responder action
Wenson Hsieh
Reported 2021-03-04 09:28:59 PST
<rdar://problem/75001149>
Attachments
Patch (4.98 KB, patch)
2021-03-04 10:00 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
For EWS (2.99 KB, patch)
2021-03-04 11:43 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-03-04 10:00:16 PST
Created attachment 422249 [details] Patch
Devin Rousso
Comment 2 2021-03-04 11:10:25 PST
Comment on attachment 422249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422249&action=review r=me > Source/WebKit/ChangeLog:9 > + Add support for the new action, such that we return `YES` iff we're in an editable context, and also such that "iff"
Wenson Hsieh
Comment 3 2021-03-04 11:23:54 PST
(In reply to Devin Rousso from comment #2) > Comment on attachment 422249 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422249&action=review > > r=me > > > Source/WebKit/ChangeLog:9 > > + Add support for the new action, such that we return `YES` iff we're in an editable context, and also such that > > "iff" It means "if and only if"! But maybe writing it out is preferable.
Wenson Hsieh
Comment 4 2021-03-04 11:43:22 PST
Created attachment 422265 [details] For EWS
Wenson Hsieh
Comment 5 2021-03-04 11:45:00 PST
(In reply to Wenson Hsieh from comment #4) > Created attachment 422265 [details] > For EWS Devin suggested this new approach (adding an "additional actions" macro) offline, which makes the patch significantly simpler (and also, eventually easier to upstream from additions).
EWS
Comment 6 2021-03-04 13:07:01 PST
Committed r273915: <https://commits.webkit.org/r273915> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422265 [details].
Note You need to log in before you can comment on or make changes to this bug.