Bug 222743 - [iOS] Add support for a new image-extraction-related responder action
Summary: [iOS] Add support for a new image-extraction-related responder action
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-04 09:28 PST by Wenson Hsieh
Modified: 2021-03-04 13:07 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.98 KB, patch)
2021-03-04 10:00 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
For EWS (2.99 KB, patch)
2021-03-04 11:43 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-03-04 09:28:59 PST 
<rdar://problem/75001149>
Comment 1 Wenson Hsieh 2021-03-04 10:00:16 PST 
Created attachment 422249 [details]
Patch
Comment 2 Devin Rousso 2021-03-04 11:10:25 PST 
Comment on attachment 422249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422249&action=review

r=me

> Source/WebKit/ChangeLog:9
> +        Add support for the new action, such that we return `YES` iff we're in an editable context, and also such that

"iff"
Comment 3 Wenson Hsieh 2021-03-04 11:23:54 PST 
(In reply to Devin Rousso from comment #2)
> Comment on attachment 422249 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422249&action=review
> 
> r=me
> 
> > Source/WebKit/ChangeLog:9
> > +        Add support for the new action, such that we return `YES` iff we're in an editable context, and also such that
> 
> "iff"

It means "if and only if"! But maybe writing it out is preferable.
Comment 4 Wenson Hsieh 2021-03-04 11:43:22 PST 
Created attachment 422265 [details]
For EWS
Comment 5 Wenson Hsieh 2021-03-04 11:45:00 PST 
(In reply to Wenson Hsieh from comment #4)
> Created attachment 422265 [details]
> For EWS

Devin suggested this new approach (adding an "additional actions" macro) offline, which makes the patch significantly simpler (and also, eventually easier to upstream from additions).
Comment 6 EWS 2021-03-04 13:07:01 PST 
Committed r273915: <https://commits.webkit.org/r273915>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422265 [details].