Bug 222732 - AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices is unnecessarily creating a NSArray twice
Summary: AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices is unn...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-04 04:39 PST by youenn fablet
Modified: 2021-03-04 09:49 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.49 KB, patch)
2021-03-04 04:44 PST, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2021-03-04 05:02 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (2.53 KB, patch)
2021-03-04 08:27 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-03-04 04:39:59 PST 
AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices is unnecessarily creating a NSArray twice
Comment 1 youenn fablet 2021-03-04 04:43:12 PST 
<rdar://problem/74621795>
Comment 2 youenn fablet 2021-03-04 04:44:00 PST 
Created attachment 422214 [details]
Patch
Comment 3 youenn fablet 2021-03-04 05:02:43 PST 
Created attachment 422215 [details]
Patch
Comment 4 Eric Carlson 2021-03-04 05:47:49 PST 
Comment on attachment 422215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422215&action=review

> Source/WebCore/ChangeLog:8
> +        Before the patch, [m_audioSession availableInputs].

Something is missing here
Comment 5 youenn fablet 2021-03-04 08:27:33 PST 
Created attachment 422231 [details]
Patch for landing
Comment 6 EWS 2021-03-04 09:49:27 PST 
Committed r273894: <https://commits.webkit.org/r273894>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422231 [details].