Bug 22273 - CTI get/put arg methods are badly named
Summary: CTI get/put arg methods are badly named
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-14 18:06 PST by Gavin Barraclough
Modified: 2008-11-14 18:57 PST (History)
0 users

See Also:

Attachments
The patch (97.66 KB, patch)
2008-11-14 18:07 PST, Gavin Barraclough 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-11-14 18:06:41 PST 
emitGetArg and emitPutArg were not symmetric operations, and were accessing completely separate sets of data.  Rename to something more sensible.
Comment 1 Gavin Barraclough 2008-11-14 18:07:12 PST 
Created attachment 25179 [details]
The patch
Comment 2 Geoffrey Garen 2008-11-14 18:10:00 PST 
Comment on attachment 25179 [details]
The patch

excellent!

r=me
Comment 3 Gavin Barraclough 2008-11-14 18:57:58 PST 
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/VM/CTI.cpp
Sending        JavaScriptCore/VM/CTI.h
Transmitting file data ...
Committed revision 38414.