Bug 22272 - The JIT code for calls is HUUUUUUUGE!
Summary: The JIT code for calls is HUUUUUUUGE!
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-14 15:59 PST by Gavin Barraclough
Modified: 2008-11-14 17:37 PST (History)
0 users

See Also:


Attachments
The patch (20.62 KB, patch)
2008-11-14 16:03 PST, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-11-14 15:59:05 PST
We should generate less of it.
Comment 1 Gavin Barraclough 2008-11-14 16:03:48 PST
Created attachment 25178 [details]
The patch

1% progression on v8 tests
Comment 2 Geoffrey Garen 2008-11-14 16:21:41 PST
Comment on attachment 25178 [details]
The patch

emitRetrieveArg

This is a fishy name.

The problem is really that emitGetArg is a bad name. So, we should rename emitGetArg to emitGetVirtualRegister. Probably a good thing to do after landing this patch.

r=me
Comment 3 Gavin Barraclough 2008-11-14 17:37:23 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/VM/CTI.cpp
Sending        JavaScriptCore/VM/CTI.h
Sending        JavaScriptCore/VM/CodeBlock.h
Sending        JavaScriptCore/VM/Machine.cpp
Sending        JavaScriptCore/VM/Machine.h
Transmitting file data ......
Committed revision 38412.