Bug 222717 - Use NO_MAIN_THREAD_WRAPPING to compile libwebrtc
Summary: Use NO_MAIN_THREAD_WRAPPING to compile libwebrtc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-04 00:59 PST by youenn fablet
Modified: 2021-03-04 09:55 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2021-03-04 01:03 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-03-04 00:59:43 PST 
<rdar://problem/74988599>
Comment 1 youenn fablet 2021-03-04 01:03:43 PST 
Created attachment 422193 [details]
Patch
Comment 2 EWS 2021-03-04 09:49:14 PST 
Committed r273893: <https://commits.webkit.org/r273893>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422193 [details].
Comment 3 Philippe Normand 2021-03-04 09:54:07 PST 
Comment on attachment 422193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422193&action=review

> Source/ThirdParty/libwebrtc/ChangeLog:10
> +        This prevents creating socket server in Web Process.

I suppose this could be useful in the cmake build as well.
Comment 4 youenn fablet 2021-03-04 09:55:34 PST 
(In reply to Philippe Normand from comment #3)
> Comment on attachment 422193 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422193&action=review
> 
> > Source/ThirdParty/libwebrtc/ChangeLog:10
> > +        This prevents creating socket server in Web Process.
> 
> I suppose this could be useful in the cmake build as well.

Yes, this is my guess to0.
Chromium is using that option.