Bug 222704 - [LFC][IFC] Make LineBox::m_inlineLevelBoxRectMap a non-root inline level box map
Summary: [LFC][IFC] Make LineBox::m_inlineLevelBoxRectMap a non-root inline level box map
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-03 19:25 PST by zalan
Modified: 2021-03-04 06:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.41 KB, patch)
2021-03-03 19:27 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-03-03 19:25:20 PST 
root inline box does not need to go in there.
Comment 1 zalan 2021-03-03 19:27:56 PST 
Created attachment 422174 [details]
Patch
Comment 2 Antti Koivisto 2021-03-03 21:21:03 PST 
Comment on attachment 422174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422174&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:92
> -    m_inlineLevelBoxRectMap.reserveInitialCapacity(numberOfRuns);
> -    m_inlineLevelBoxRectMap.set(&rootLayoutBox, &m_rootInlineBox);
> +    m_nonRootInlineLevelBoxMap.reserveInitialCapacity(numberOfRuns);

Does it need one less capacity now?
Comment 3 EWS 2021-03-04 06:22:51 PST 
Committed r273887: <https://commits.webkit.org/r273887>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422174 [details].
Comment 4 Radar WebKit Bug Importer 2021-03-04 06:23:13 PST 
<rdar://problem/75033710>
Comment 5 zalan 2021-03-04 06:25:01 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 422174 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422174&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:92
> > -    m_inlineLevelBoxRectMap.reserveInitialCapacity(numberOfRuns);
> > -    m_inlineLevelBoxRectMap.set(&rootLayoutBox, &m_rootInlineBox);
> > +    m_nonRootInlineLevelBoxMap.reserveInitialCapacity(numberOfRuns);
> 
> Does it need one less capacity now?
yeah I was going to talk to you about it. we need a better approximation for this.