Bug 222695 - [JSC] ENABLE(JIT_CAGE) requires HAVE(JIT_CAGE)
Summary: [JSC] ENABLE(JIT_CAGE) requires HAVE(JIT_CAGE)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-03 16:02 PST by Yusuke Suzuki
Modified: 2021-03-03 20:21 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2021-03-03 16:02 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-03-03 16:02:03 PST 
[JSC] ENABLE(JIT_CAGE) requires HAVE(JIT_CAGE)
Comment 1 Yusuke Suzuki 2021-03-03 16:02:40 PST 
Created attachment 422157 [details]
Patch
Comment 2 Alexey Proskuryakov 2021-03-03 16:05:44 PST 
Comment on attachment 422157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422157&action=review

> Source/WTF/wtf/PlatformEnable.h:894
> +#if OS(DARWIN) && ENABLE(JIT) && USE(APPLE_INTERNAL_SDK) && CPU(ARM64E) && HAVE(JIT_CAGE) && ((defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) || (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000))

Can we drop the version checks now?
Comment 3 Yusuke Suzuki 2021-03-03 20:14:26 PST 
Comment on attachment 422157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422157&action=review

>> Source/WTF/wtf/PlatformEnable.h:894
>> +#if OS(DARWIN) && ENABLE(JIT) && USE(APPLE_INTERNAL_SDK) && CPU(ARM64E) && HAVE(JIT_CAGE) && ((defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) || (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000))
> 
> Can we drop the version checks now?

I personally prefer controlling it here since this is easy & less-error-prone compared to relying on HAVE(JIT_CAGE), but I'm OK.
Comment 4 Yusuke Suzuki 2021-03-03 20:20:05 PST 
Committed r273870 (234831@main): <https://commits.webkit.org/234831@main>
Comment 5 Radar WebKit Bug Importer 2021-03-03 20:21:15 PST 
<rdar://problem/75018054>