RESOLVED FIXED 222695
[JSC] ENABLE(JIT_CAGE) requires HAVE(JIT_CAGE) 
https://bugs.webkit.org/show_bug.cgi?id=222695
Summary [JSC] ENABLE(JIT_CAGE) requires HAVE(JIT_CAGE)
Yusuke Suzuki
Reported 2021-03-03 16:02:03 PST
[JSC] ENABLE(JIT_CAGE) requires HAVE(JIT_CAGE)
Attachments
Patch (1.60 KB, patch)
2021-03-03 16:02 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-03-03 16:02:40 PST
Created attachment 422157 [details] Patch
Alexey Proskuryakov
Comment 2 2021-03-03 16:05:44 PST
Comment on attachment 422157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422157&action=review > Source/WTF/wtf/PlatformEnable.h:894 > +#if OS(DARWIN) && ENABLE(JIT) && USE(APPLE_INTERNAL_SDK) && CPU(ARM64E) && HAVE(JIT_CAGE) && ((defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) || (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000)) Can we drop the version checks now?
Yusuke Suzuki
Comment 3 2021-03-03 20:14:26 PST
Comment on attachment 422157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422157&action=review >> Source/WTF/wtf/PlatformEnable.h:894 >> +#if OS(DARWIN) && ENABLE(JIT) && USE(APPLE_INTERNAL_SDK) && CPU(ARM64E) && HAVE(JIT_CAGE) && ((defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) || (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000)) > > Can we drop the version checks now? I personally prefer controlling it here since this is easy & less-error-prone compared to relying on HAVE(JIT_CAGE), but I'm OK.
Yusuke Suzuki
Comment 4 2021-03-03 20:20:05 PST
Committed r273870 (234831@main): <https://commits.webkit.org/234831@main>
Radar WebKit Bug Importer
Comment 5 2021-03-03 20:21:15 PST
<rdar://problem/75018054>
Note You need to log in before you can comment on or make changes to this bug.