Bug 222687 - [build.webkit.org] run buildbot checkconfig in services ews
Summary: [build.webkit.org] run buildbot checkconfig in services ews
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-03 14:15 PST by Aakash Jain
Modified: 2021-03-13 08:20 PST (History)
5 users (show)

See Also:


Attachments
Patch (9.98 KB, patch)
2021-03-08 13:09 PST, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (10.41 KB, patch)
2021-03-12 10:46 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-03-03 14:15:43 PST
We should run 'buildbot checkconfig' in services ews for build.webkit.org. We already run this command for ews, but not for build.webkit.org yet.

Even though most of the checks done by 'buildbot checkconfig' are already covered by our unit-tests, it sometimes find issues not covered by unit-tests. So, it would be good to run it in ews (in services-ews).
Comment 1 Aakash Jain 2021-03-08 13:09:47 PST
Created attachment 422608 [details]
Patch
Comment 2 Aakash Jain 2021-03-08 13:24:34 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/1/builds/1256
Comment 3 Radar WebKit Bug Importer 2021-03-10 14:16:15 PST
<rdar://problem/75281935>
Comment 4 Aakash Jain 2021-03-12 10:46:15 PST
Created attachment 423063 [details]
Patch
Comment 5 Aakash Jain 2021-03-12 10:47:36 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/1/builds/1497 (see step  11 and 13).
Comment 6 Jonathan Bedard 2021-03-12 13:07:47 PST
Comment on attachment 423063 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423063&action=review

> Tools/CISupport/ews-build/steps.py:1259
> +    directory = 'build/Tools/CISupport/ews-build'

Why is this in the shared class?
Comment 7 Jonathan Bedard 2021-03-12 13:10:13 PST
Comment on attachment 423063 [details]
Patch

r=me, seems like the directory may be there to make the linter happy, but I would make the directory something that makes this fact more clear
Comment 8 Aakash Jain 2021-03-12 18:29:06 PST
(In reply to Jonathan Bedard from comment #6)
> Why is this in the shared class?
No strong reason. Wanted to keep this as a valid step as well (in case anyone uses this as a build step directly for some reason in future).
Comment 9 EWS 2021-03-13 05:21:38 PST
commit-queue failed to commit attachment 423063 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 10 EWS 2021-03-13 06:20:54 PST
commit-queue failed to commit attachment 423063 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 11 EWS 2021-03-13 06:57:49 PST
commit-queue failed to commit attachment 423063 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 12 EWS 2021-03-13 08:20:47 PST
Committed r274388: <https://commits.webkit.org/r274388>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423063 [details].