Bug 222681 - Nulllptr crash in DeleteSelectionCommand::handleGeneralDelete()
Summary: Nulllptr crash in DeleteSelectionCommand::handleGeneralDelete()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-03 12:43 PST by Ryosuke Niwa
Modified: 2021-03-03 17:51 PST (History)
4 users (show)

See Also:

Attachments
Fixes the bug (1.71 KB, patch)
2021-03-03 12:48 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-03-03 12:43:04 PST 
In the following line, m_downstreamEnd.deprecatedNode() could be null.
} else if (!m_downstreamEnd.deprecatedNode()->isDescendantOf(*node)) {

<rdar://problem/72769130>
Comment 1 Ryosuke Niwa 2021-03-03 12:48:39 PST 
Created attachment 422137 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2021-03-03 17:50:45 PST 
Comment on attachment 422137 [details]
Fixes the bug

Clearing flags on attachment: 422137

Committed r273866 (234827@main): <https://commits.webkit.org/234827@main>
Comment 3 Ryosuke Niwa 2021-03-03 17:50:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2021-03-03 17:51:38 PST 
<rdar://problem/75013167>