Bug 222648 - [JSC] Simplify OSRExit side state materialization
Summary: [JSC] Simplify OSRExit side state materialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-03 03:43 PST by Yusuke Suzuki
Modified: 2021-03-05 18:26 PST (History)
8 users (show)

See Also:

Attachments
Patch (39.54 KB, patch)
2021-03-03 03:50 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (39.54 KB, patch)
2021-03-03 03:57 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (39.89 KB, patch)
2021-03-03 04:11 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (39.73 KB, patch)
2021-03-03 04:18 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (39.75 KB, patch)
2021-03-03 04:31 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (39.78 KB, patch)
2021-03-03 04:38 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (38.91 KB, patch)
2021-03-03 05:14 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (38.95 KB, patch)
2021-03-05 12:50 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (38.95 KB, patch)
2021-03-05 13:04 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-03-03 03:43:41 PST 
[JSC] Simplify OSRExit side state materialization
Comment 1 Yusuke Suzuki 2021-03-03 03:50:38 PST 
Created attachment 422057 [details]
Patch
Comment 2 Yusuke Suzuki 2021-03-03 03:57:05 PST 
Created attachment 422061 [details]
Patch
Comment 3 Yusuke Suzuki 2021-03-03 04:11:53 PST 
Created attachment 422062 [details]
Patch
Comment 4 Yusuke Suzuki 2021-03-03 04:18:50 PST 
Created attachment 422063 [details]
Patch
Comment 5 Yusuke Suzuki 2021-03-03 04:31:18 PST 
Created attachment 422064 [details]
Patch
Comment 6 Yusuke Suzuki 2021-03-03 04:38:19 PST 
Created attachment 422065 [details]
Patch
Comment 7 Yusuke Suzuki 2021-03-03 05:14:27 PST 
Created attachment 422069 [details]
Patch
Comment 8 Caio Lima 2021-03-05 06:39:44 PST 
Comment on attachment 422069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422069&action=review

I tested the patch locally with 2 changes below, and it passes tests.

> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:636
> +#if USE(JSVALUE64_32)

It should be `#if USE(JSVALUE64_32)`

> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:659
> +            break

Missing '''
Comment 9 Caio Lima 2021-03-05 06:46:08 PST 
Comment on attachment 422069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422069&action=review

Patch LGTM. Informal r+. It also fixes support for double on `CheckpointOSRExitSideState`!

>> Source/JavaScriptCore/dfg/DFGOSRExit.cpp:636
>> +#if USE(JSVALUE64_32)
> 
> It should be `#if USE(JSVALUE64_32)`

I meant `#if USE(JSVALUE32_64)`
Comment 10 Yusuke Suzuki 2021-03-05 12:50:42 PST 
Created attachment 422398 [details]
Patch
Comment 11 Yusuke Suzuki 2021-03-05 13:04:38 PST 
Created attachment 422400 [details]
Patch
Comment 12 Keith Miller 2021-03-05 15:36:51 PST 
Comment on attachment 422400 [details]
Patch

I didn't know probe leaked memory...

r=me.
Comment 13 EWS 2021-03-05 18:25:53 PST 
Committed r274024: <https://commits.webkit.org/r274024>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422400 [details].
Comment 14 Radar WebKit Bug Importer 2021-03-05 18:26:15 PST 
<rdar://problem/75122234>