RESOLVED FIXED222642
Drop support for <object usemap> making <object> interactive 
https://bugs.webkit.org/show_bug.cgi?id=222642
Summary Drop support for <object usemap> making <object> interactive
Attachments
Patch (15.57 KB, patch)
2021-11-11 01:54 PST, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (8.48 KB, patch)
2021-11-11 02:29 PST, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.70 KB, patch)
2021-11-11 06:06 PST, Carlos Garcia Campos 		koivisto: review+
DetailsFormatted DiffDiff
Patch (11.19 KB, patch)
2021-11-11 10:23 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-10 00:01:15 PST
<rdar://problem/75253297>
Tim Nguyen (:ntim)
Comment 2 2021-11-11 01:54:22 PST
Created attachment 443922 [details] Patch
EWS Watchlist
Comment 3 2021-11-11 01:55:11 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 4 2021-11-11 02:09:35 PST
Comment on attachment 443922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443922&action=review > Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLObjectElement.cpp:-117 > - DOM_HTML_OBJECT_ELEMENT_PROP_USE_MAP, This is public (but deprecated) API. We can't just remove it, because of our backwards API/ABI compatibility policy. It's ok to remove the functionality, but keeping the public api doing nothing, maybe just showing a warning. I can do it ig you prefer it.
Tim Nguyen (:ntim)
Comment 5 2021-11-11 02:24:47 PST
(In reply to Carlos Garcia Campos from comment #4) > Comment on attachment 443922 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443922&action=review > > > Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLObjectElement.cpp:-117 > > - DOM_HTML_OBJECT_ELEMENT_PROP_USE_MAP, > > This is public (but deprecated) API. We can't just remove it, because of our > backwards API/ABI compatibility policy. It's ok to remove the functionality, > but keeping the public api doing nothing, maybe just showing a warning. I > can do it ig you prefer it. I would appreciate it if you could, the best I can probably do for now is undo the GTK changes
Carlos Garcia Campos
Comment 6 2021-11-11 02:28:58 PST
I'll submit an updated version of the patch later today.
Tim Nguyen (:ntim)
Comment 7 2021-11-11 02:29:11 PST
Created attachment 443925 [details] Patch
Carlos Garcia Campos
Comment 8 2021-11-11 06:06:57 PST
Created attachment 443942 [details] Patch
Tim Nguyen (:ntim)
Comment 9 2021-11-11 10:23:16 PST
Created attachment 443967 [details] Patch
Tim Nguyen (:ntim)
Comment 10 2021-11-11 10:27:41 PST
Committed r285638 (244139@main): <https://commits.webkit.org/244139@main>
Note You need to log in before you can comment on or make changes to this bug.