Bug 222624 - Fix Depth24 Stencil8 support on Simulator for Metal Angle backend
Summary: Fix Depth24 Stencil8 support on Simulator for Metal Angle backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: anglemetal
  Show dependency tree / graph
 
Reported: 2021-03-02 15:34 PST by Kyle Piddington
Modified: 2021-03-04 14:09 PST (History)
6 users (show)

See Also:

Attachments
Patch (72.39 KB, patch)
2021-03-02 15:34 PST, Kyle Piddington 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-03-02 15:34:08 PST 
Fix Depth24 Stencil8 support on Simulator for Metal Angle backend
Comment 1 Kyle Piddington 2021-03-02 15:34:24 PST 
Created attachment 422007 [details]
Patch
Comment 2 EWS Watchlist 2021-03-02 15:35:38 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Dean Jackson 2021-03-03 10:29:27 PST 
Comment on attachment 422007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422007&action=review

> Source/ThirdParty/ANGLE/ChangeLog:9
> +	Fixes the following tests:
> +	fast/canvas/webgl/context-creation-attributes.html
> +	fast/canvas/webgl/webgl-depth-texture.html 
> +	webgl/1.0.3/conformance/misc/webgl-specific.html
> +	webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html

FYI: Seems like your editor is using tabs, which will be rejected by the commit check.

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm:40
> -
> +            

Did all these spaces come from an update to the script?
Comment 4 Dean Jackson 2021-03-03 10:58:13 PST 
Committed r273823
Comment 5 Radar WebKit Bug Importer 2021-03-03 10:59:24 PST 
<rdar://problem/74993209>