Bug 22262 - Clicking close ("X") button in docked Web Inspector clears Web Inspector but doesn't close it
Summary: Clicking close ("X") button in docked Web Inspector clears Web Inspector but ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2008-11-14 07:45 PST by Adam Roben (:aroben)
Modified: 2009-01-07 07:58 PST (History)
1 user (show)

See Also:

Attachments
Patch + ChangeLog (8.92 KB, patch)
2009-01-06 17:38 PST, Adam Roben (:aroben) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2008-11-14 07:45:05 PST 
To reproduce:

1. Go to any page (e.g., <http://webkit.org/>)
2. Open the Inspector
3. Dock the Inspector into the WebView
4. Click the close ("X") button in the upper-left of the Inspector

The Inspector's contents get cleared (i.e., the DOM tree disappears), but the Inspector doesn't close.

Note that bug 14270 introduced the close button in order to give a way to close the docked Inspector, but clearly not everything needed for that bug fix is implemented yet on Windows.
Comment 1 Adam Roben (:aroben) 2008-11-14 07:45:39 PST 
<rdar://problem/6371873>
Comment 2 Adam Roben (:aroben) 2009-01-06 17:38:46 PST 
Created attachment 26482 [details]
Patch + ChangeLog
Comment 3 Darin Adler 2009-01-06 21:53:15 PST 
Comment on attachment 26482 [details]
Patch + ChangeLog

r=me

Hard for me to swallow those C style casts thought.
Comment 4 Adam Roben (:aroben) 2009-01-07 07:40:53 PST 
(In reply to comment #3)
> (From update of attachment 26482 [details] [review])
> r=me
> 
> Hard for me to swallow those C style casts thought.

OK, I'll change them to reinterpret_casts (and simplify them a bit) before landing.

Thanks for the review!
Comment 5 Adam Roben (:aroben) 2009-01-07 07:58:41 PST 
Committed in r39682 <http://trac.webkit.org/changeset/39682>