Bug 222616 – Add Apple Silicon Devices to Big Sur builders and testers.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Matt Lewis]

We are bringing Apple Silicon Devices online for Big Sur building and testing.

[Radar WebKit Bug Importer]

<rdar://problem/74946994>

[Matt Lewis]

Created attachment 421993 [details]
Patch

[Jonathan Bedard]

(In reply to Matt Lewis from comment #2)
> Created attachment 421993 [details]
> Patch

Looks like the patch is out of date.

[Jonathan Bedard]

Comment on attachment 421993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421993&action=review

> Tools/CISupport/build-webkit-org/config.json:3
> +                    { "name": "bot105", "platform": "mac-bigsur" },

Why are we adding spaces after each platform, when they were not there before?

[Matt Lewis]

(In reply to Jonathan Bedard from comment #4)
> Comment on attachment 421993 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421993&action=review
> 
> > Tools/CISupport/build-webkit-org/config.json:3
> > +                    { "name": "bot105", "platform": "mac-bigsur" },
> 
> Why are we adding spaces after each platform, when they were not there
> before?

Correct.(In reply to Jonathan Bedard from comment #3)
> (In reply to Matt Lewis from comment #2)
> > Created attachment 421993 [details]
> > Patch
> 
> Looks like the patch is out of date.
Yep going to need a rebase

[Matt Lewis]

Created attachment 422114 [details]
Patch

[Jonathan Bedard]

(In reply to Matt Lewis from comment #6)
> Created attachment 422114 [details]
> Patch

Failing services EWS

[Matt Lewis]

Created attachment 422143 [details]
Patch

[Matt Lewis]

(In reply to Jonathan Bedard from comment #7)
> (In reply to Matt Lewis from comment #6)
> > Created attachment 422114 [details]
> > Patch
> 
> Failing services EWS
I made a mistake in the triggers. Fixing

[Matt Lewis]

Created attachment 422147 [details]
Patch

[Matt Lewis]

Created attachment 422148 [details]
Patch

[Ryan Haddad]

Comment on attachment 422148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422148&action=review

> Tools/CISupport/build-webkit-org/config.json:204
> +                      "platform": "mac-bigsur", "configuration": "debug", "architectures": ["arm64"],

Worth verifying, but I think only specifying arm64 will make these fail to find archives since we are only producing multi-arch ones.

> Tools/CISupport/build-webkit-org/config.json:208
> +                      "platform": "mac-bigsur", "configuration": "release", "architectures": ["arm64"],

Ditto.

[Aakash Jain]

(In reply to Ryan Haddad from comment #12)
> Worth verifying, but I think only specifying arm64 will make these fail to
> find archives since we are only producing multi-arch ones.
Would be good to test this patch on dev instance.

[Matt Lewis]

Created attachment 422152 [details]
Patch

[Matt Lewis]

(In reply to Aakash Jain from comment #13)
> (In reply to Ryan Haddad from comment #12)
> > Worth verifying, but I think only specifying arm64 will make these fail to
> > find archives since we are only producing multi-arch ones.
> Would be good to test this patch on dev instance.

Doing this now. Looks to be fine.

[Matt Lewis]

(In reply to Matt Lewis from comment #15)
> (In reply to Aakash Jain from comment #13)
> > (In reply to Ryan Haddad from comment #12)
> > > Worth verifying, but I think only specifying arm64 will make these fail to
> > > find archives since we are only producing multi-arch ones.
> > Would be good to test this patch on dev instance.
> 
> Doing this now. Looks to be fine.

the build and triggered testing for JSC

https://build.webkit-dev.org/#/builders/48/builds/5
https://build.webkit-dev.org/#/builders/81/builds/2

[Matt Lewis]

Created attachment 422254 [details]
Patch

[Matt Lewis]

Re running dev instance builds and test, will link them here when they complete.

[Matt Lewis]

build:
https://build.webkit-dev.org/#/builders/75/builds/9
(debug already linked earlier)
testers:
https://build.webkit-dev.org/#/builders/85/builds/1
https://build.webkit-dev.org/#/builders/82/builds/1
https://build.webkit-dev.org/#/builders/86/builds/1
https://build.webkit-dev.org/#/builders/83/builds/1
https://build.webkit-dev.org/#/builders/84/builds/1

All triggered properly and are testing normally.

[Ryan Haddad]

The layout test runs above didn't work to an unrelated change on the dev instance. It is working now: https://build.webkit-dev.org/#/builders/85/builds/2

This should be good for review.

[Alexey Proskuryakov]

Comment on attachment 422254 [details]
Patch

We are still specifying Buildbot.BuildArchitecture.SixtyFourBit on some of the queues. Would it make sense to differentiate x86_64 and Apple Silicon using Buildbot.BuildArchitecture? I don't remember what effect is has.

[Matt Lewis]

Comment on attachment 422254 [details]
Patch

Clearing flags on attachment: 422254

Committed r273926 (234880@main): <https://commits.webkit.org/234880@main>

[Matt Lewis]

All reviewed patches have been landed.  Closing bug.