Bug 222600 – [build.webkit.org] Rename master_buildbot2.cfg to master.cfg

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

master_buildbot2.cfg was created for buildbot 2 instance (see https://bugs.webkit.org/show_bug.cgi?id=218102#c0), as at that time master.cfg was used for old buildbot. Now that we have fully switched to new buildbot, and have deleted master.cfg for old buildbot, we should rename master_buildbot2.cfg to master.cfg

[Radar WebKit Bug Importer]

<rdar://problem/75218344>

[Aakash Jain]

Created attachment 428030 [details]
Patch

[Aakash Jain]

Created attachment 428035 [details]
[fast-cq] Patch

[Darin Adler]

Comment on attachment 428035 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428035&action=review

> Tools/ChangeLog:3
> +        [build.webkit.org] Rename master_buildbot2.cfg to master.cfg

Seems fine, but you don’t say *why*

[Aakash Jain]

(In reply to Darin Adler from comment #4)
> Seems fine, but you don’t say *why*
Simply because that's the default name used by buildbot (e.g.: https://github.com/buildbot/buildbot/blob/master/master/buildbot/master.py#L88), and for consistency with our other buildbot configurations (they also use master.cfg file name).

[EWS]

Committed r277275 (237542@main): <https://commits.webkit.org/237542@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428035 [details].

[Darin Adler]

(In reply to Aakash Jain from comment #5)
> (In reply to Darin Adler from comment #4)
> > Seems fine, but you don’t say *why*
> Simply because that's the default name used by buildbot (e.g.:
> https://github.com/buildbot/buildbot/blob/master/master/buildbot/master.
> py#L88), and for consistency with our other buildbot configurations (they
> also use master.cfg file name).

We should say such things in change logs. The most important question to answer in any change log is "why".

[Aakash Jain]

(In reply to Darin Adler from comment #7)
> We should say such things in change logs. The most important question to answer in any change log is "why".
ok. Will keep that in mind in future.