WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
22259
Make all opcodes use eax as their final result register
https://bugs.webkit.org/show_bug.cgi?id=22259
Summary
Make all opcodes use eax as their final result register
Cameron Zwarich (cpst)
Reported
2008-11-14 01:28:16 PST
We should adopt a convention of using eax as the final result register. This is pretty close to what we actually do in practice: only one case of op_add and some resolve opcodes returning two results differ.
Attachments
Proposed patch
(3.71 KB, patch)
2008-11-14 02:14 PST
,
Cameron Zwarich (cpst)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1
2008-11-14 02:14:48 PST
Created
attachment 25164
[details]
Proposed patch This patch is no performance change when I test with networking on (but Safari and Mail closed). I will test again with networking off before landing.
Darin Adler
Comment 2
2008-11-14 09:18:23 PST
Comment on
attachment 25164
[details]
Proposed patch r=me
Cameron Zwarich (cpst)
Comment 3
2008-11-14 23:44:17 PST
Landed in
r38419
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug