Bug 222589 – WebKitLegacy needs to keep JSDOMWindow even though it is used while its origin is not set

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

WebKitLegacy needs to keep JSDOMWindow even though it is used while its origin is not set

[youenn fablet]

<rdar://problem/74258258>

[youenn fablet]

Created attachment 421917 [details]
Patch

[Geoffrey Garen]

Comment on attachment 421917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421917&action=review

r=me

> Source/WebCore/bindings/js/JSWindowProxy.cpp:109
> +        if (!localWindow.document()->haveInitializedSecurityOrigin() && localWindow.document()->settings().windowObjectAlwaysInitializedWithSecurityOriginEnabled())

I wonder if this should include a linked on or after check -- or just be a linked on or after check? Would be nice to avoid unnecessary divergence in web platform behavior.

[youenn fablet]

(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 421917 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421917&action=review
> 
> r=me
> 
> > Source/WebCore/bindings/js/JSWindowProxy.cpp:109
> > +        if (!localWindow.document()->haveInitializedSecurityOrigin() && localWindow.document()->settings().windowObjectAlwaysInitializedWithSecurityOriginEnabled())
> 
> I wonder if this should include a linked on or after check -- or just be a
> linked on or after check? Would be nice to avoid unnecessary divergence in
> web platform behavior.

I do not really know.
Are WK1 APIs good enough to handle that case, ie provide easy hooks to delay what people are doing to the point where the origin is set?
I guess we can do that as a follow-up.

[EWS]

Committed r273817: <https://commits.webkit.org/r273817>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421917 [details].