Bug 222582 – REGRESSION(r270691): It's impossible to use MobileAsset fonts on macOS

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

REGRESSION(r270691): It's impossible to use MobileAsset fonts on macOS

[Myles C. Maxfield]

Created attachment 421893 [details]
WIP

[Myles C. Maxfield]

<rdar://problem/74877450>

[Myles C. Maxfield]

Created attachment 421895 [details]
WIP

[Myles C. Maxfield]

Created attachment 421905 [details]
Patch

[Per Arne Vollan]

Comment on attachment 421905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421905&action=review

Thanks! R=me.

> Source/WebKit/UIProcess/WebPageProxy.cpp:10413
> +    SandboxExtension::createHandleForMachLookup("com.apple.mobileassetd.v2"_s, WTF::nullopt, mobileAssetHandleV2);

Perhaps a new HAVE define could be added to protect this?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1103
> +        "com.apple.mobileassetd.v2"

Is adding this needed when __MAC_OS_X_VERSION_MIN_REQUIRED <= 110000? We should do our best to avoid adding access to new services, also for older OSes.

[Per Arne Vollan]

Comment on attachment 421905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421905&action=review

>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1103
>> +        "com.apple.mobileassetd.v2"
> 
> Is adding this needed when __MAC_OS_X_VERSION_MIN_REQUIRED <= 110000? We should do our best to avoid adding access to new services, also for older OSes.

Perhaps you could avoid this by having the extension rule below be present for older OSes as well? Then access to this service could be granted through the SPI.

[Myles C. Maxfield]

Created attachment 422002 [details]
Patch for committing

[EWS]

Committed r273784: <https://commits.webkit.org/r273784>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422002 [details].