RESOLVED WONTFIX 22258
Avoid defining ExceptionCode multiple times 
https://bugs.webkit.org/show_bug.cgi?id=22258
Summary Avoid defining ExceptionCode multiple times
Julien Chaffraix
Reported 2008-11-14 00:18:24 PST
Currently when we need ExceptionCode, we just define it again instead of including ExceptionCode.h. Patch forthcoming.
Attachments
Trivial fix: including ExceptionCode (24.06 KB, patch)
2008-11-14 00:24 PST, Julien Chaffraix 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2008-11-14 00:24:21 PST
Created attachment 25163 [details] Trivial fix: including ExceptionCode
Darin Adler
Comment 2 2008-11-14 09:16:09 PST
Comment on attachment 25163 [details] Trivial fix: including ExceptionCode Why is this an improvement? This slows down compilation and I don't see any obvious benefits from making the change.
Eric Seidel (no email)
Comment 3 2008-11-14 11:55:23 PST
Comment on attachment 25163 [details] Trivial fix: including ExceptionCode I agree with Darin. We intentionally are using forward declarations here. marking r-, but certainly feel free to mark r? again if there are other reasons we'd want this that I'm missing...
Julien Chaffraix
Comment 4 2008-11-15 08:08:22 PST
> Why is this an improvement? I do not think defining the same name multiple times is a good practice. But if it does benefit the compilation time then it is ok (I had misread a response about the benefit of those multiple definitions on IRC). Closing the bug as WONTFIX.
Note You need to log in before you can comment on or make changes to this bug.