Bug 222570 - [GPUP] Clean up LayoutTests/gpu-process/TestExpectations related to media tests
Summary: [GPUP] Clean up LayoutTests/gpu-process/TestExpectations related to media tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-01 11:51 PST by Peng Liu
Modified: 2021-03-01 15:12 PST (History)
6 users (show)

See Also:


Attachments
Patch (5.57 KB, patch)
2021-03-01 12:00 PST, Peng Liu
no flags Details | Formatted Diff | Diff
Revise the patch based on Jon's comments (5.59 KB, patch)
2021-03-01 13:10 PST, Peng Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2021-03-01 11:51:24 PST
[GPUP] Clean up LayoutTests/gpu-process/TestExpectations related to media tests
Comment 1 Peng Liu 2021-03-01 12:00:07 PST
Created attachment 421854 [details]
Patch
Comment 2 Jon Lee 2021-03-01 12:55:30 PST
Comment on attachment 421854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review

> LayoutTests/platform/wk2/TestExpectations:306
> +fast/images/animated-image-mp4-crash.html [ Timeout ]

results.webkit.org doesn't seem to show any timeouts for this test.

> LayoutTests/platform/wk2/TestExpectations:322
> +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ]

All three of these appear to only be flaky crashing on WK2 debug bots.
Comment 3 Peng Liu 2021-03-01 12:56:53 PST
Comment on attachment 421854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review

>> LayoutTests/platform/wk2/TestExpectations:306
>> +fast/images/animated-image-mp4-crash.html [ Timeout ]
> 
> results.webkit.org doesn't seem to show any timeouts for this test.

I can reproduce the issue locally with stress tests.
Comment 4 Peng Liu 2021-03-01 13:01:26 PST
Comment on attachment 421854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review

>> LayoutTests/platform/wk2/TestExpectations:322
>> +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ]
> 
> All three of these appear to only be flaky crashing on WK2 debug bots.

Right. They are assertion failures.
Comment 5 Jon Lee 2021-03-01 13:02:56 PST
Comment on attachment 421854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review

>>> LayoutTests/platform/wk2/TestExpectations:322
>>> +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ]
>> 
>> All three of these appear to only be flaky crashing on WK2 debug bots.
> 
> Right. They are assertion failures.

Then shouldn't these be annotated with [ Debug ]?
Comment 6 Peng Liu 2021-03-01 13:10:25 PST
Created attachment 421858 [details]
Revise the patch based on Jon's comments
Comment 7 Peng Liu 2021-03-01 13:11:11 PST
Comment on attachment 421854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review

>>>> LayoutTests/platform/wk2/TestExpectations:322
>>>> +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ]
>>> 
>>> All three of these appear to only be flaky crashing on WK2 debug bots.
>> 
>> Right. They are assertion failures.
> 
> Then shouldn't these be annotated with [ Debug ]?

Correct. Fixed.
Comment 8 Eric Carlson 2021-03-01 14:40:09 PST
Comment on attachment 421858 [details]
Revise the patch based on Jon's comments

rs=me
Comment 9 EWS 2021-03-01 15:02:50 PST
commit-queue failed to commit attachment 421858 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 10 EWS 2021-03-01 15:11:09 PST
Committed r273696: <https://commits.webkit.org/r273696>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421858 [details].
Comment 11 Radar WebKit Bug Importer 2021-03-01 15:12:14 PST
<rdar://problem/74893907>