[GPUP] Clean up LayoutTests/gpu-process/TestExpectations related to media tests
Created attachment 421854 [details] Patch
Comment on attachment 421854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review > LayoutTests/platform/wk2/TestExpectations:306 > +fast/images/animated-image-mp4-crash.html [ Timeout ] results.webkit.org doesn't seem to show any timeouts for this test. > LayoutTests/platform/wk2/TestExpectations:322 > +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ] All three of these appear to only be flaky crashing on WK2 debug bots.
Comment on attachment 421854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review >> LayoutTests/platform/wk2/TestExpectations:306 >> +fast/images/animated-image-mp4-crash.html [ Timeout ] > > results.webkit.org doesn't seem to show any timeouts for this test. I can reproduce the issue locally with stress tests.
Comment on attachment 421854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review >> LayoutTests/platform/wk2/TestExpectations:322 >> +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ] > > All three of these appear to only be flaky crashing on WK2 debug bots. Right. They are assertion failures.
Comment on attachment 421854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review >>> LayoutTests/platform/wk2/TestExpectations:322 >>> +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ] >> >> All three of these appear to only be flaky crashing on WK2 debug bots. > > Right. They are assertion failures. Then shouldn't these be annotated with [ Debug ]?
Created attachment 421858 [details] Revise the patch based on Jon's comments
Comment on attachment 421854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421854&action=review >>>> LayoutTests/platform/wk2/TestExpectations:322 >>>> +imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html [ Crash Pass ] >>> >>> All three of these appear to only be flaky crashing on WK2 debug bots. >> >> Right. They are assertion failures. > > Then shouldn't these be annotated with [ Debug ]? Correct. Fixed.
Comment on attachment 421858 [details] Revise the patch based on Jon's comments rs=me
commit-queue failed to commit attachment 421858 [details] to WebKit repository. To retry, please set cq+ flag again.
Committed r273696: <https://commits.webkit.org/r273696> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421858 [details].
<rdar://problem/74893907>